If you changed your home page to a blank one, as previously mentioned, just go to settings and set your homepage to whatever you like. Many antivirus and anti-malware programs now use blank pages to prevent dangerous URLs from executing code or tricking you into taking action. Removing malware from your PC can also lead to missing files and settings within the browser, which didn’t get repaired/replaced after the malware was removed.Īside from the above two scenarios, you should probably leave the about:blank functionality alone. Slight risk is that we can't really have automated tests for this, so QA would be good.If you get blank pages regularly, you would want to stop malware or viruses first because they can corrupt the browser, and then you can uninstall and reinstall Chrome, Firefox, Safari, or whatever you use. Why is the change risky/not risky? (and alternatives if risky): This is a relatively well understood patch that moves a few lines of code in shutdown sanitization to happen earlier than before (because we added code that returned before they could be run).Without the fix, it should show a blank page on startup, with the fix, the custom homepage should be shown. If yes, steps to reproduce: I can reliably reproduce given the steps in comment 12.Has the fix been verified in Nightly?: No.Is this code covered by automated tests?: No.User impact if declined: Custom home page is broken with clearing data on shutdown settings applied.r=mak!,baku Beta/Release Uplift Approval Request The solution is to remove the pending shutdown sanitization immediately after the sanitization is done.Īs far as I can see there was never really a point in having it happen after session principalĬleanup finished, since in case of a crash it would not run the principal cleanup again next startup,įor good measure I also moved the new tab container sanitization to happen earlier in this function,īug 1554167 - Remove pending shutdown sanitization immediately after shutdown sanitization finishes. Where, for reasons I don't fully understand, it would race and conflict with loading the home page, The result is that the shutdown sanitization would be left dangling and run again on next startup, The function execution before it would call removePendingSanitization("shutdown") later onĪnd thus remove the pending shutdown sanitization (which, in fact, had completed successfully earlier).
Set their preferences to clear all storage on shutdown anyway. The SanitizeOnShutdown function to avoid cleaning principals by permission if the user had
0 kommentar(er)
